From 51aca56cc49af221e2e001917fe62d6e124264ce Mon Sep 17 00:00:00 2001 From: Tobias Kahse Date: Sat, 17 Sep 2016 15:15:13 +0200 Subject: [PATCH] test: refactored test-crypto-random.js Replaced `var` by `const` for constant variables, enforced strict equality check, and replaced custom callback execution check by `common.mustCall`. Signed-off-by: Tobias Kahse --- test/parallel/test-crypto-random.js | 25 ++++++------------------- 1 file changed, 6 insertions(+), 19 deletions(-) diff --git a/test/parallel/test-crypto-random.js b/test/parallel/test-crypto-random.js index b4e36dfa045c05..6866c8c08186ee 100644 --- a/test/parallel/test-crypto-random.js +++ b/test/parallel/test-crypto-random.js @@ -1,12 +1,12 @@ 'use strict'; -var common = require('../common'); -var assert = require('assert'); +const common = require('../common'); +const assert = require('assert'); if (!common.hasCrypto) { common.skip('missing crypto'); return; } -var crypto = require('crypto'); +const crypto = require('crypto'); crypto.DEFAULT_ENCODING = 'buffer'; @@ -29,27 +29,14 @@ process.setMaxListeners(256); }); [0, 1, 2, 4, 16, 256, 1024].forEach(function(len) { - f(len, checkCall(function(ex, buf) { - assert.equal(null, ex); - assert.equal(len, buf.length); + f(len, common.mustCall(function(ex, buf) { + assert.strictEqual(null, ex); + assert.strictEqual(len, buf.length); assert.ok(Buffer.isBuffer(buf)); })); }); }); -// assert that the callback is indeed called -function checkCall(cb, desc) { - var called_ = false; - - process.on('exit', function() { - assert.equal(true, called_, desc || ('callback not called: ' + cb)); - }); - - return function() { - return called_ = true, cb.apply(cb, Array.prototype.slice.call(arguments)); - }; -} - // #5126, "FATAL ERROR: v8::Object::SetIndexedPropertiesToExternalArrayData() // length exceeds max acceptable value" assert.throws(function() {