From 5eca1b03b456f859197d1cd369dc9e0bc6f965f0 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Tue, 17 Feb 2015 19:35:59 +0100 Subject: [PATCH] src: fix add-on builds, partially revert 8aed9d66 Commit 8aed9d66 ("src: cleanup `Isolate::GetCurrent()`") breaks building add-ons because of the following: In file included from ../node_modules/nan/nan.h:27:0, from ../src/binding.cc:18: /home/bnoordhuis/src/v1.x/src/node_object_wrap.h: In member function 'v8::Local node::ObjectWrap::handle()': /home/bnoordhuis/src/v1.x/src/node_object_wrap.h:39:46: error: base operand of '->' has non-pointer type 'v8::Persistent' return v8::Local::New(handle_->GetIsolate(), persistent()); Mea culpa, I was one of the reviewers. --- src/node_object_wrap.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/node_object_wrap.h b/src/node_object_wrap.h index 93c73a05752dcf..d00e1484b7c10c 100644 --- a/src/node_object_wrap.h +++ b/src/node_object_wrap.h @@ -36,7 +36,7 @@ class ObjectWrap { inline v8::Local handle() { - return v8::Local::New(handle_->GetIsolate(), persistent()); + return handle(v8::Isolate::GetCurrent()); }