Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build script: generate unexpected hyperlink for fullwidth comma #1612

Closed
marswong opened this issue Apr 2, 2018 · 7 comments
Closed

build script: generate unexpected hyperlink for fullwidth comma #1612

marswong opened this issue Apr 2, 2018 · 7 comments

Comments

@marswong
Copy link
Contributor

marswong commented Apr 2, 2018

When translating the docs, we need to use other input source, at present the script seems to mark the end of hyperlink with halfwidth comma, but if we use a fullwidth comma it would generate unexpected hyperlink, for example:

// generate expected "http://localhost:3000"
visit http://localhost:3000, and you will see a message 'Hello World'

// generate unexpected "http://localhost:3000,xxx"
visit http://localhost:3000,and you will see a message 'Hello World'
@ghost
Copy link

ghost commented Dec 17, 2018

@marswong:This has been fixed at #1943,and the result seems fine by using "<>" to quote the link——
image

@stevemao
Copy link
Contributor

It should be fixed at the parser level so that you don't need to wrap the link with "<>"

@ghost
Copy link

ghost commented Dec 17, 2018

@stevemao :OK. But this is a temporary fix :)

@ghost
Copy link

ghost commented Dec 17, 2018

@marswong , @stevemao , @fhemberger :I don't know when and how to fix this parse. But for a temporary fix, I submitted this and if this parser is fixed, I'll change back.

Thanks all!!!

@UziTech
Copy link

UziTech commented Mar 15, 2019

I think the only way to prevent a full-width comma from being part of the url is to surround the urls with <> or add a space before the comma

@XhmikosR
Copy link
Contributor

Agreed, the only proper solution would be to disallow GitHub flavored links and require all of them to be wrapped in <>. But it's not a simple change, there's so much old content and inconsistencies.

For starters, we should check how is this addressed upstream in core. Then we need to verify the release post template and tools follow this scheme, enable the check in the markdown linter and have some kind of basic link checker set up.

@ovflowd
Copy link
Member

ovflowd commented Mar 12, 2023

Closing as the legacy build script is not used anymore.

@ovflowd ovflowd closed this as not planned Won't fix, can't repro, duplicate, stale Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants