-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build script: generate unexpected hyperlink for fullwidth comma #1612
Comments
It should be fixed at the parser level so that you don't need to wrap the link with "<>" |
@stevemao :OK. But this is a temporary fix :) |
@marswong , @stevemao , @fhemberger :I don't know when and how to fix this parse. But for a temporary fix, I submitted this and if this parser is fixed, I'll change back. Thanks all!!! |
I think the only way to prevent a full-width comma from being part of the url is to surround the urls with |
Agreed, the only proper solution would be to disallow GitHub flavored links and require all of them to be wrapped in For starters, we should check how is this addressed upstream in core. Then we need to verify the release post template and tools follow this scheme, enable the check in the markdown linter and have some kind of basic link checker set up. |
Closing as the legacy build script is not used anymore. |
When translating the docs, we need to use other input source, at present the script seems to mark the end of hyperlink with
halfwidth comma
, but if we use afullwidth comma
it would generate unexpected hyperlink, for example:The text was updated successfully, but these errors were encountered: