Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thanking contributors #2632

Closed
Trott opened this issue Sep 30, 2019 · 9 comments · Fixed by #2635
Closed

Thanking contributors #2632

Trott opened this issue Sep 30, 2019 · 9 comments · Fixed by #2635

Comments

@Trott
Copy link
Member

Trott commented Sep 30, 2019

symfony.com has a box at the bottom of their main page titled "They Help Us Make Symfony" that thanks an apparently-random contributor. We should totally do something like this IMO.

Screen Shot 2019-09-30 at 1 45 28 PM

@jrjohnson
Copy link

That's my face! Which I bring up because there is some magic here in that it thanks you specifically if it knows who you are. If not, then it's random. Both of which I think you should steal (borrow).

@Trott Trott added the good first issue Issues for newcomers label Oct 1, 2019
@KeziahMoselle
Copy link
Contributor

Can I work on this please ?

@Trott
Copy link
Member Author

Trott commented Oct 1, 2019

Can I work on this please ?

No need to ask! Go for it!

@Trott Trott removed the good first issue Issues for newcomers label Oct 1, 2019
@KeziahMoselle
Copy link
Contributor

Thank you !
Is there anything I need to know first ?

@Trott Trott added the good first issue Issues for newcomers label Oct 1, 2019
@Trott
Copy link
Member Author

Trott commented Oct 1, 2019

Thank you !
Is there anything I need to know first ?

Yes. You can start with the README file.

@KeziahMoselle
Copy link
Contributor

KeziahMoselle commented Oct 1, 2019

I mean, for the design and the location of the card (in the footer I guess ?)
Edit: I saw there was a contributor-list package in /scripts/contributor-list should I use it ? (I don't think so, but asking anyway) 😄

@Trott
Copy link
Member Author

Trott commented Oct 1, 2019

I mean, for the design and the location of the card (in the footer I guess ?)
Edit: I saw there was a contributor-list package in /scripts/contributor-list should I use it ? (I don't think so, but asking anyway) 😄

I don't have any good insight on how best to implement this, I'm sorry to say. I'd say look at what's there and try to comply with existing style.

@KeziahMoselle
Copy link
Contributor

No problem ! Thank you

@Trott
Copy link
Member Author

Trott commented Oct 3, 2019

I'm going to remove the good-first-issue label here because there's a very active draft PR at #2635 to implement this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants