Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Search Component, add to Navbar #6131

Closed
bmuenzenmeyer opened this issue Nov 19, 2023 · 5 comments
Closed

Create Search Component, add to Navbar #6131

bmuenzenmeyer opened this issue Nov 19, 2023 · 5 comments
Labels
website redesign Issue/PR part of the Node.js Website Redesign

Comments

@bmuenzenmeyer
Copy link
Collaborator

Create a Search component using the new figma design (direct link).

Read more about the Node.js Website redesign

This component does not do anything quite yet, but future Orama Search stories will expand upon it.


Before You Start...


Details

standalone

image
image

integrated into Navbar

image
image

Not sure where to start breaking down the figma? Read this short guide
🌐 This story requires some internationalization support. Slow down!

Suggested Props

Name type comments
onChange function () => {} no-op for now

Storybook

Add a storybook story file components/Common/Search/index.stories.tsx, which exercises each of the component's states.

There are 2 states to capture within styles and stories:

  • Light
  • Dark
@bmuenzenmeyer bmuenzenmeyer added help wanted good first issue Issues for newcomers website redesign Issue/PR part of the Node.js Website Redesign labels Nov 19, 2023
@bmuenzenmeyer bmuenzenmeyer moved this to 🔖 Ready in Website Redesign Nov 19, 2023
@TheFossilDev
Copy link
Contributor

TheFossilDev commented Nov 20, 2023

This would be my second issue since I'm also working on the changelogModal but is it alright if I get going on this too? Of course others are welcome ✌🏼

@AugustinMauroy
Copy link
Member

AugustinMauroy commented Nov 20, 2023

gives someone else a chance to contribute but thank you for your interest in the project. 😄

@Ragnarrlothbrok
Copy link

Hi, I would like to work on this.

@bmuenzenmeyer
Copy link
Collaborator Author

Thanks for your interest. We don't assign tickets if we can help it. Feel free to submit a pull request if you have time.
Reference 🍪 https://www.redhat.com/en/blog/dont-lick-cookie

@ovflowd ovflowd moved this from 🔖 Ready to 🏗 In progress in Website Redesign Nov 20, 2023
@ovflowd ovflowd removed good first issue Issues for newcomers help wanted labels Nov 20, 2023
@ovflowd
Copy link
Member

ovflowd commented Nov 20, 2023

Hey there, sadly, this issue is already locked-in and not available for grabs.

(This is specific to this issue) as we have a partner (3rd party company) being involved on the development of the search functionality of the Website. (cc @micheleriva)

@AugustinMauroy AugustinMauroy moved this from 🏗 In progress to ✅ Done in Website Redesign Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website redesign Issue/PR part of the Node.js Website Redesign
Projects
Status: Done
Development

No branches or pull requests

5 participants