-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Search
Component, add to Navbar
#6131
Comments
This would be my second issue since I'm also working on the changelogModal but is it alright if I get going on this too? Of course others are welcome ✌🏼 |
gives someone else a chance to contribute but thank you for your interest in the project. 😄 |
Hi, I would like to work on this. |
Thanks for your interest. We don't assign tickets if we can help it. Feel free to submit a pull request if you have time. |
Hey there, sadly, this issue is already locked-in and not available for grabs. (This is specific to this issue) as we have a partner (3rd party company) being involved on the development of the search functionality of the Website. (cc @micheleriva) |
Create a
Search
component using the new figma design (direct link).This component does not do anything quite yet, but future Orama Search stories will expand upon it.
Before You Start...
Details
standalone
integrated into
Navbar
❓ Not sure where to start breaking down the figma? Read this short guide
🌐 This story requires some internationalization support. Slow down!
Search
within theCommon
directory that contains all the new code.magnifying-glass
from https://heroicons.com/, already a dependencyNavbar
per the figmacomponents.header.search.empty
with the valueStart typing...
components.header.search.noResults
with the valueNo results found
components.header.search.noResultsSuggestion
with the valuePerhaps try another query?
Suggested Props
onChange
function
() => {}
no-op for nowStorybook
Add a storybook story file
components/Common/Search/index.stories.tsx
, which exercises each of the component's states.There are 2 states to capture within styles and stories:
The text was updated successfully, but these errors were encountered: