Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): Create sidebar component family #6109

Closed

Conversation

smonolo
Copy link

@smonolo smonolo commented Nov 11, 2023

Description

This PR introduces changes for issue #6061. Code features new Sidebar, SidebarGroup and SidebarItem components.

Validation

image

image

Related Issues

Resolves #6061

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@smonolo smonolo requested a review from a team as a code owner November 11, 2023 17:54
Copy link

vercel bot commented Nov 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2023 7:52pm

@smonolo smonolo changed the title feat(components): Create sidebar family feat(components): Create sidebar component family Nov 11, 2023
@mikeesto
Copy link
Member

Appreciate the PR. This one has been open for a couple of weeks now and looks like it's almost ready to land: #6065 . Perhaps you could collaborate there if you have any suggestions.

@smonolo
Copy link
Author

smonolo commented Nov 12, 2023

Hey @mikeesto, thanks for letting me know! I thought #6065 was a bit outdated and going kinda slowly based on the fact that it was opened 2 weeks ago, but I'll make sure to contribute there if needed. Let me know if this PR should be closed

@bmuenzenmeyer
Copy link
Collaborator

Let me know if this PR should be closed

yes I think we can close it. I agree with Mike that though the timing wasn't right this time, we really welcome folks contributing however they can, even if it's a stray PR review or issue report. Every bit helps!

@smonolo smonolo deleted the 6061-create-sidebar-component-family branch November 17, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Sidebar Component family
3 participants