From 58a1cd2c770321609ab10884786315fee3caa192 Mon Sep 17 00:00:00 2001
From: James M Snell <jasnell@gmail.com>
Date: Tue, 3 Dec 2019 17:56:04 -0800
Subject: [PATCH] quic: address multiple nits

---
 doc/api/quic.md          | 16 ++++++++--------
 src/node_quic_session.cc |  2 +-
 src/node_quic_session.h  |  4 +++-
 src/node_sockaddr-inl.h  |  4 ++--
 4 files changed, 14 insertions(+), 12 deletions(-)

diff --git a/doc/api/quic.md b/doc/api/quic.md
index 09bd518847..d8a65e7910 100644
--- a/doc/api/quic.md
+++ b/doc/api/quic.md
@@ -58,7 +58,7 @@ socket.on('listening', () => {
 
 ## QUIC Basics
 
-QUIC is a UDP-based network transport protocol that includes built in security
+QUIC is a UDP-based network transport protocol that includes built-in security
 via TLS 1.3, flow control, error correction, connection migration,
 multiplexing, and more.
 
@@ -388,7 +388,7 @@ added: REPLACEME
 
 * Type: {BigInt}
 
-A `BigInt` representing the number of retranmissions caused by delayed
+A `BigInt` representing the number of retransmissions caused by delayed
 acknowledgements.
 
 #### quicsession.address
@@ -448,7 +448,7 @@ added: REPLACEME
 
 * Type: {number}
 
-The total number of unacknoledged bytes this QUIC endpoint has tramitted
+The total number of unacknowledged bytes this QUIC endpoint has transmitted
 to the connected peer.
 
 #### quicsession.bytesReceived
@@ -630,7 +630,7 @@ added: REPLACEME
 
 * Type: {BigInt}
 
-A `BigInt` representing the number of lost-packet retranmissions that have been
+A `BigInt` representing the number of lost-packet retransmissions that have been
 performed on this `QuicSession`.
 
 #### quicsession.maxDataLeft
@@ -650,7 +650,7 @@ added: REPLACEME
 
 * Type: {BigInt}
 
-A `BigInt` representing the maximum number of in flight bytes recorded
+A `BigInt` representing the maximum number of in-flight bytes recorded
 for this `QuicSession`.
 
 #### quicsession.maxStreams
@@ -711,7 +711,7 @@ added: REPLACEME
 
 * Type: {BigInt}
 
-A `BigInt` representing the total number of `QuicStreams` initated by the
+A `BigInt` representing the total number of `QuicStreams` initiated by the
 connected peer.
 
 #### quicsession.remoteAddress
@@ -928,7 +928,7 @@ added: REPLACEME
 -->
 
 * `servername` {String} A DNS name to associate with the given context.
-* `context` {Object} A TLS SecureContext to associate with the `servername`.
+* `context` {tls.SecureContext} A TLS SecureContext to associate with the `servername`.
 
 TBD
 
@@ -1604,7 +1604,7 @@ added: REPLACEME
 -->
 * Type: {boolean}
 
-True if dataflow on the `QuicStream` was prematured terminated.
+True if dataflow on the `QuicStream` was prematurely terminated.
 
 #### quicstream.bidirectional
 <!--YAML
diff --git a/src/node_quic_session.cc b/src/node_quic_session.cc
index 1ef6787dfd..5b16d11b63 100644
--- a/src/node_quic_session.cc
+++ b/src/node_quic_session.cc
@@ -590,7 +590,7 @@ void JSQuicSessionListener::OnSessionTicket(int size, SSL_SESSION* session) {
 
   AllocatedBuffer session_ticket = env->AllocateManaged(size);
   unsigned char* session_data =
-    reinterpret_cast<unsigned char*>(session_ticket.data());
+      reinterpret_cast<unsigned char*>(session_ticket.data());
   memset(session_data, 0, size);
   i2d_SSL_SESSION(session, &session_data);
   if (!session_ticket.empty())
diff --git a/src/node_quic_session.h b/src/node_quic_session.h
index ddefa97df7..c3c2b2cb6f 100644
--- a/src/node_quic_session.h
+++ b/src/node_quic_session.h
@@ -195,7 +195,9 @@ enum QuicSessionStatsIdx : int {
   IDX_QUIC_SESSION_STATS_RETRY_COUNT,
   IDX_QUIC_SESSION_STATS_LOSS_RETRANSMIT_COUNT,
   IDX_QUIC_SESSION_STATS_ACK_DELAY_RETRANSMIT_COUNT,
-  IDX_QUIC_SESSION_STATS_PATH_VALIDATION_SUCCESS_COUNT,IDX_QUIC_SESSION_STATS_PATH_VALIDATION_FAILURE_COUNT,IDX_QUIC_SESSION_STATS_MAX_BYTES_IN_FLIGHT
+  IDX_QUIC_SESSION_STATS_PATH_VALIDATION_SUCCESS_COUNT,
+  IDX_QUIC_SESSION_STATS_PATH_VALIDATION_FAILURE_COUNT,
+  IDX_QUIC_SESSION_STATS_MAX_BYTES_IN_FLIGHT
 };
 
 class QuicSessionListener {
diff --git a/src/node_sockaddr-inl.h b/src/node_sockaddr-inl.h
index 6454c10b8b..daec9b6425 100644
--- a/src/node_sockaddr-inl.h
+++ b/src/node_sockaddr-inl.h
@@ -132,12 +132,12 @@ SocketAddress::SocketAddress(const SocketAddress& addr) {
   memcpy(&address_, &addr.address_, addr.GetLength());
 }
 
-inline SocketAddress& SocketAddress::operator=(const sockaddr* addr) {
+SocketAddress& SocketAddress::operator=(const sockaddr* addr) {
   memcpy(&address_, addr, GetLength(addr));
   return *this;
 }
 
-inline SocketAddress& SocketAddress::operator=(const SocketAddress& addr) {
+SocketAddress& SocketAddress::operator=(const SocketAddress& addr) {
   memcpy(&address_, &addr.address_, addr.GetLength());
 }