We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
origin
ConnectOptions interface doesn't include an origin field that's required for the HTTP CONNECT.
ConnectOptions
Furthermore, it appears that the agent.connect({}) currently fails to execute without the origin field.
agent.connect({})
const agent = new Agent(); agent.connect({ origin: "https://example.com", path: "/robots.txt" });
This gives a TypeScript error for unknown "origin" field.
Origin is accepted.
Any
The text was updated successfully, but these errors were encountered:
Would you like to send a PR?
Sorry, something went wrong.
@metcoder95 I took a stub at it in #2532. But not sure what to do with backward compat, so I left it an optional field.
Type changes are always considered minor changes, it's fine to make the field required (especially since it doesn't work without it).
Successfully merging a pull request may close this issue.
Bug Description
ConnectOptions
interface doesn't include anorigin
field that's required for the HTTP CONNECT.Furthermore, it appears that the
agent.connect({})
currently fails to execute without theorigin
field.Reproducible By
This gives a TypeScript error for unknown "origin" field.
Expected Behavior
Origin is accepted.
Environment
Any
The text was updated successfully, but these errors were encountered: