Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next branch purged of semver-major changes? #2771

Closed
Uzlopak opened this issue Feb 16, 2024 · 4 comments · Fixed by #2772
Closed

next branch purged of semver-major changes? #2771

Uzlopak opened this issue Feb 16, 2024 · 4 comments · Fixed by #2772

Comments

@Uzlopak
Copy link
Contributor

Uzlopak commented Feb 16, 2024

@ronag

Did your force push removed the semver-major changes? E.g. llhttp 9.2.0 is back to v8 in next.
@ronag
Copy link
Member

ronag commented Feb 16, 2024

What PR did that land in?

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Feb 16, 2024

With #2701 llhttp was upgraded to 9.2.0

Also the changes of this PR of yours seems to be removed from next branch #2724

We probably can fix this as we have the commits still in the sync-next branch of @metcoder95 and maybe have to cherrypick them?!

@ronag
Copy link
Member

ronag commented Feb 16, 2024

I will fix this.

@ronag ronag mentioned this issue Feb 16, 2024
Merged
@ronag ronag closed this as completed Feb 16, 2024
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Feb 16, 2024

Awesome. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Missing commits nodejs/undici
2 participants
@ronag @Uzlopak