Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TIMEOUT_IDLE should include event loop lag #3553

Closed
ronag opened this issue Sep 5, 2024 · 1 comment · Fixed by #3552
Closed

TIMEOUT_IDLE should include event loop lag #3553

ronag opened this issue Sep 5, 2024 · 1 comment · Fixed by #3552
Assignees
@Uzlopak
Labels
bug Something isn't working

Comments

@ronag
Copy link
Member

ronag commented Sep 5, 2024 •
edited
Loading

Tee TIMEOUT_IDLE state used by the keep alive timeout should include the event loop lag since it's tracking a remote servers time.

I think the recent fast timers event loop lag fixes has broken this. We should not use fast timers for this state.
@ronag ronag added the bug Something isn't working label Sep 5, 2024
@Uzlopak Uzlopak mentioned this issue Sep 5, 2024
Merged
@Uzlopak
Copy link
Contributor

Uzlopak commented Sep 5, 2024

Provided PR #3554 ;)

@Uzlopak Uzlopak mentioned this issue Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Uzlopak Uzlopak

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use fasttimers for all connection timeouts nodejs/undici
2 participants
@ronag @Uzlopak