You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
i.e. we have the ability to requeue builds of any version, but that will rebuild all assets and they'll get new binaries and new hash digests in SHASUMS which lead to verification problems when anyone tries to check that the binaries included in a Docker image that depends on these binaries don't match the digests that we publish.
But, there's regularly reasons we want to queue builds of old versions, such as when we add a new recipe and want binaries for an old version (or just want to try it out on the most recent version); or when a recipe is broken for some version but gets fixed.
I'm not sure how this would work because currently we just have a version that passes through the queue, perhaps we have <version>[ recipe[, recipe[...]]] in the queue and pass that along and when recipes are specified we only process those.
The text was updated successfully, but these errors were encountered:
It looks like the current shape of the queue file is just the version. Just to check, you would like to add the recipes in comma separated format after a space.
I'm not tied to a particular implementation of this, just thinking aloud given the current form, if you come up with a better idea then that's fine too but I guess keeping complexity low would be a worthy goal.
When I was in build.sh yesterday I was thinking that maybe it should be split out to just build individual recipes, and then coordinate them elsewhere. Maybe even the queueing mechanism is responsible for iterating over the recipe list and then the queue processor is just a dumb receiver that works through its list. The only complication would be that they all need fetch-source to be run first, so there'd need to be a check "has the source for this version been fetched?" before each run.
We also have this in the TODO list #22 and that could potentially be bundled up with this work. The builds are now taking 10h and the new x64-debug is going to extend that more; so it's a long wait if your build is done but in staging.
We have this problem with running re-builds of old versions: nodejs/docker-node#1853
i.e. we have the ability to requeue builds of any version, but that will rebuild all assets and they'll get new binaries and new hash digests in SHASUMS which lead to verification problems when anyone tries to check that the binaries included in a Docker image that depends on these binaries don't match the digests that we publish.
But, there's regularly reasons we want to queue builds of old versions, such as when we add a new recipe and want binaries for an old version (or just want to try it out on the most recent version); or when a recipe is broken for some version but gets fixed.
I'm not sure how this would work because currently we just have a version that passes through the queue, perhaps we have
<version>[ recipe[, recipe[...]]]
in the queue and pass that along and when recipes are specified we only process those.The text was updated successfully, but these errors were encountered: