Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Knowledge base articles need to be reviewed ahead of pulling them in #126

Closed
3 tasks
keywordnew opened this issue Jan 9, 2019 · 4 comments
Closed
3 tasks

Comments

@keywordnew
Copy link
Contributor

This issue was raised in the nodejs.org repo about content that was submitted by Nodejitsu to the Node.js project (not Website Redesign specifically).

We have a RFC process for bringing in new content. The content has yet to be reviewed but I think it can be funnelled into our existing RFC process.

Interested reviewers would need to visit nodejs.org/en/knowledge:

  • Pick an item by following the links to github and getting the content OR
  • Pick an item then requesting a link to the content from the github repo by posting a request on this issue
  • Review/assess/update that content and follow the RFC process for submission here
@ayliao
Copy link
Contributor

ayliao commented Jan 10, 2019

These could be great good first issues, but how do we decide which articles (if any) we actually want to RFC and bring into the website? Do we just make PRs for each article and review them individually?

@keywordnew
Copy link
Contributor Author

keywordnew commented Jan 11, 2019

I'd lean towards individual PRs.

#105 was a massive PR with multiple sections, which was decided to be reviewed piecemeal once merged, partly because of the extra effort that would be needed to split up the PR.

But that content was comparatively up-to-date. This content under discussion needs to be checked for relevance.

Pinging @amiller-gh for guidance on how this review would fit into the RFC process.

@ayliao
Copy link
Contributor

ayliao commented Jan 11, 2019

Yeah I was leaning towards individual PRs as well, since it seems a lot more manageable to review each article on its own for relevance and correctness.

p.s. I think your link may be broken, this is the page under question, right? https://nodejs.org/en/knowledge/

@Trott
Copy link
Member

Trott commented Apr 22, 2023

I've unarchived this repo so I can close all PRs and issues before re-archiving.

@Trott Trott closed this as completed Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants