Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend node.info([buildRef,[modules]]) #1739

Closed
spaccabit opened this issue Jan 18, 2017 · 5 comments
Closed

Extend node.info([buildRef,[modules]]) #1739

spaccabit opened this issue Jan 18, 2017 · 5 comments
Assignees

Comments

@spaccabit
Copy link

Hi at all,
I'm trying different builds with different settings to understand how nodeMcu.
The more difficulty that I met it is to identify the build of firmware and the selected modules.

I would suggest adding to node.info optional parameters:

buildRef - returns the short hash of the commit to which the build refers
modules - returns a table containing the list of modules selected on user_modules.h

@djphoenix
Copy link
Contributor

For cloud builds there are some information that printed on bootup.
Not sure how it works at all. @marcelstoer I think you may describe it?

So I agree for expose that data somewhere in Lua-level.

@marcelstoer
Copy link
Member

My cloud builder simply redefines NODE_VERSION and BUILD_DATE in user_version.h. The Git revision is extracted by running git rev-parse HEAD.

There are more details here #449 (comment).

@stale
Copy link

stale bot commented Jun 7, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@HHHartmann
Copy link
Member

I am working at #2799 and would like to add these informations too.
The idea is to return all of them in node.info.

@HHHartmann HHHartmann reopened this Jul 5, 2019
@stale stale bot removed stale labels Jul 5, 2019
@HHHartmann HHHartmann self-assigned this Jul 5, 2019
@HHHartmann HHHartmann mentioned this issue Jul 12, 2019
4 tasks
@HHHartmann
Copy link
Member

fixed by #2830

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants