Can't compile in Docker after PR #2845

[vsky279]

Expected behavior

After PR #2845 and PR #2844 (probably only one of them being toxic) I am not able to compile dev version with Docker (Windows 10).

Actual behavior

CC app/user/user_main.c
In file included from user_main.c:25:0:
../../sdk-overrides/include/espconn.h:1:1: error: expected identifier or '(' before '.' token
 ../../app/include/lwip/app/espconn.h
 ^
user_main.c: In function 'user_process_input':
user_main.c:298:32: error: 'input_sig' undeclared (first use in this function)
     return task_post_low(input_sig, force);
                                ^
user_main.c:298:32: note: each undeclared identifier is reported only once for each function it appears in
user_main.c: In function 'user_init':
user_main.c:340:5: error: 'input_sig' undeclared (first use in this function)
     input_sig = task_get_id(handle_input);
     ^
make[2]: *** [.output/eagle/debug/obj/user_main.o] Error 1
make[2]: Leaving directory `/opt/nodemcu-firmware/app/user'
make[1]: *** [.subdirs] Error 2
make[1]: Leaving directory `/opt/nodemcu-firmware/app'
make: *** [.subdirs] Error 2
make: Leaving directory `/opt/nodemcu-firmware'

Test code

No test code is needed. I just can't compile clean pull of dev version with the error above.

NodeMCU version

dev

Hardware

N/A

[HHHartmann]

Can confirm

[marcelstoer]

PR #2844

How is that one related? It only changed documentation for the ESP32 branch.

[marcelstoer]

@HHHartmann since the NodeMCU CI build is obviously ok do you think this may be related to trusty vs xenial (and therefore related to marcelstoer/docker-nodemcu-build#69)?

[vsky279]

PR #2844

How is that one related? It only changed documentation for the ESP32 branch.

Then it is not related. Of course.
Sorry I did not go into detail. I just saw that after these two PRs compile fails.

[HHHartmann]

seems to be that sdk-overrides/include/espconn.h is a link which does not get checked correctly out under windows as mentioned elsewhere. It contains

../../app/include/lwip/app/espconn.h

[HHHartmann]

After copying app/include/lwip/app/espconn.h to sdk-overrides/include/espconn.h it compiles.

[marcelstoer]

not get checked correctly out under windows

Ah, that explains why I cannot reproduce this on macOS.

[HHHartmann]

Fixed on dev now

[marcelstoer]

This was a bit of tumbleweed. The actual culprit was 98c2c05#diff-08924738929fb5bc35be7f4839a1f1c5 from @TerryE merged in #2843.

Sorry I forgot to close this issue after I merged @jmattsson's fix.