Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge upstream ruby-build changes #27

Closed
charlesbjohnson opened this issue Feb 6, 2015 · 5 comments
Closed

Merge upstream ruby-build changes #27

charlesbjohnson opened this issue Feb 6, 2015 · 5 comments

Comments

@charlesbjohnson
Copy link
Member

Howdy,

I have several branches lined up for the recent iojs releases (1.0.0 through 1.1.0) that I want to eventually get merged in. However, they fail to build because the current implementation of checksum verification assumes sha1 which is incompatible with the sha256 backed checksums being used for iojs releases. As such, I would need to do some tweaking beyond the typical one-liners I've been adding to share/node-build in order to get the iojs releases to properly build.

Before I embark on any changes that would cause us to further divert from ruby-build, however, I thought it might be worthwhile to pull in the compatible upstream changes/features that have been made in ruby-build. Considering the difference in build versions (201300310 vs 20150130), I think a few things have changed 😛.

What are your thoughts? I'm more than happy to see this process through and make a PR for it, but I just wanted to make sure that you would be receptive to these changes before I spend the time making them. It might also be worth discussing how to handle future upstream changes.

Thanks!

@charlesbjohnson
Copy link
Member Author

Hey @OiNutter I'm sure you are busy but even a quick 👍 or 👎 would be perfect.

@OiNutter
Copy link
Contributor

Hi

Yeah, sorry, just not been able to get to even look at some of this stuff. Definitely on board with getting nodenv up to date with the latest rbenv/ruby-build changes but not sure when I'm going to have chance to look at that. If you've got time and are willing to do it and submit a pull request then go for it. I'll try and be a bit sharper and checking it out and responding this time.

@jasonkarns
Copy link
Member

I just merged #53 which brings us up to Oct 2013.

And I just opened #54 which brings us to 2014. But #54 needs some work before it can be merged. @charlesbjohnson do you think you could help get the tests correct in #54 so we can continue?

@jasonkarns
Copy link
Member

Keeping this open as a tracker, but I'm steadily merging in updates from ruby-build upstream. As of now, we're up to June 2014 v20140524

@jasonkarns
Copy link
Member

current with latest ruby build tag (v20151024) as of Oct 24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants