Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid calling fallback function twice (#198) #201

Merged
merged 1 commit into from
May 30, 2018
Merged

fix: avoid calling fallback function twice (#198) #201

merged 1 commit into from
May 30, 2018

Conversation

duartemendes
Copy link
Contributor

No description provided.

@ghost ghost added the in progress label May 27, 2018
lance
lance reviewed May 28, 2018
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although a test for this would be nice.

@lance lance self-assigned this May 28, 2018
@lance lance added the bug label May 28, 2018
@duartemendes
Copy link
Contributor Author

@lance test added.

@lance lance merged commit b561a43 into nodeshift:master May 30, 2018
@ghost ghost removed the in progress label May 30, 2018
@lance
Copy link
Member

lance commented May 30, 2018

@duartemendes thanks again for your contribution!

@lance lance mentioned this pull request May 31, 2018
Closed
@lholmquist lholmquist mentioned this pull request May 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance lance lance left review comments

Assignees

@lance lance

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duartemendes @lance