Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to add notes unless user has edit_device permission #52

Closed
jon-nfc opened this issue Jun 7, 2024 · 5 comments
Closed

unable to add notes unless user has edit_device permission #52

jon-nfc opened this issue Jun 7, 2024 · 5 comments
Assignees
Labels
impact::3 Migrated from Gitlab This issue/PR was migrated from GitLab see #213 type::bug Type for Issues and Merge Requests. Can also be used in discussion in comments and commits
Milestone

Comments

@jon-nfc
Copy link
Member

jon-nfc commented Jun 7, 2024

the adding of notes to a device requires that the user has add_device permission.

implementation

@method_decorator(auth_decorator.permission_required("itam.change_device", raise_exception=True))
def post(self, request, *args, **kwargs):

this implementation is an issue as the note form is part of a formset.

@jon-nfc
Copy link
Member Author

jon-nfc commented Jun 7, 2024

added 5m of time spent

@jon-nfc
Copy link
Member Author

jon-nfc commented Jun 7, 2024

marked this issue as related to #49

@jon-nfc
Copy link
Member Author

jon-nfc commented Jun 17, 2024

mentioned in commit 7821611

@jon-nfc
Copy link
Member Author

jon-nfc commented Jun 17, 2024

mentioned in commit a6e569e

@jon-nfc
Copy link
Member Author

jon-nfc commented Jun 17, 2024

mentioned in commit 2bbf78d

@jon-nfc jon-nfc self-assigned this Aug 8, 2024
@jon-nfc jon-nfc closed this as completed Aug 8, 2024
@jon-nfc jon-nfc added the Migrated from Gitlab This issue/PR was migrated from GitLab see #213 label Aug 8, 2024
@jon-nfc jon-nfc mentioned this issue Aug 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact::3 Migrated from Gitlab This issue/PR was migrated from GitLab see #213 type::bug Type for Issues and Merge Requests. Can also be used in discussion in comments and commits
Projects
Archived in project
Development

No branches or pull requests

1 participant