From c5becb6b0df9d19bdb43cb2515feb5546a15e176 Mon Sep 17 00:00:00 2001 From: nohwnd Date: Thu, 24 Sep 2020 10:45:05 +0200 Subject: [PATCH] Invert the switch because it will be still backwards in the final release --- src/Microsoft.TestPlatform.Build/Tasks/VSTestTask.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/Microsoft.TestPlatform.Build/Tasks/VSTestTask.cs b/src/Microsoft.TestPlatform.Build/Tasks/VSTestTask.cs index 2d151decb3..ca01cbc268 100644 --- a/src/Microsoft.TestPlatform.Build/Tasks/VSTestTask.cs +++ b/src/Microsoft.TestPlatform.Build/Tasks/VSTestTask.cs @@ -182,7 +182,8 @@ public override bool Execute() // Avoid logging "Task returned false but did not log an error." on test failure, because we don't // write MSBuild error. https://github.com/dotnet/msbuild/blob/51a1071f8871e0c93afbaf1b2ac2c9e59c7b6491/src/Framework/IBuildEngine7.cs#L12 var allowfailureWithoutError = BuildEngine.GetType().GetProperty("AllowFailureWithoutError"); - allowfailureWithoutError?.SetValue(BuildEngine, true); + // setting this to false because the switch is implemented backwards and it won't be fixed till next release + allowfailureWithoutError?.SetValue(BuildEngine, false); vsTestForwardingApp = new VSTestForwardingApp(this.VSTestConsolePath, this.CreateArgument()); if (!string.IsNullOrEmpty(this.VSTestFramework))