Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Update to ACVM v0.11.0 #159

Closed
1 task done
phated opened this issue May 5, 2023 · 0 comments · Fixed by #151
Closed
1 task done

Update to ACVM v0.11.0 #159

phated opened this issue May 5, 2023 · 0 comments · Fixed by #151
Assignees
@phated
Labels
enhancement New feature or request

Comments

@phated
Copy link
Contributor

phated commented May 5, 2023

Problem

ACVM v0.11.0 changed the backend traits to allow failures by many functions needing to return Result. It also added keccak.

Proposed solution

Update the project to v0.11.0 by updating the trait implementations and avoiding unwrap or panic in the codebase. Also, remove the duplicated keccak code which was added prior to 0.11 support.

Alternatives considered

No response

Additional context

No response

Submission Checklist

  • Once I hit submit, I will assign this issue to the Project Board with the appropriate tags.
@phated phated added the enhancement New feature or request label May 5, 2023
@phated phated self-assigned this May 5, 2023
@phated phated linked a pull request May 5, 2023 that will close this issue
feat!: Update to ACVM v0.11.0 #151
Merged
@phated phated mentioned this issue May 5, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@phated phated

Labels
enhancement New feature or request
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: Update to ACVM v0.11.0 noir-lang/acvm-backend-barretenberg
1 participant
@phated