Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added public_witness wasm utils #22

Merged
merged 3 commits into from
Jun 7, 2023
Merged

Conversation

sirasistant
Copy link
Contributor

Related issue(s)

Resolves #21

Description

Summary of changes

Adds get_return_witness and get_public_parameters_witness to the wasm export

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

Additional context

@TomAFrench
Copy link
Member

Can properly review and merge this next week. I don't think this fully resolves #21 though?

We can get a witness map containing the public parameters and the return values but not the public inputs (parameters + return value) without manually merging them in JS.

@sirasistant
Copy link
Contributor Author

Added a binding for the public_witness one. I'd like to also keep the separated params/return because those are useful for aztec3 right now, but it's true that in the future we will use get_public_witness directly

Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We should add some tests for this (despite it being relatively simple logic) but we can do that in a separate PR.

src/public_witness.rs Show resolved Hide resolved
@TomAFrench TomAFrench merged commit b0bd3ac into master Jun 7, 2023
@github-actions github-actions bot mentioned this pull request Jun 7, 2023
TomAFrench added a commit that referenced this pull request Jun 7, 2023
* master:
  feat: added public_witness wasm utils (#22)
@github-actions github-actions bot mentioned this pull request Jun 26, 2023
@TomAFrench TomAFrench deleted the arv/get_public_witness branch July 19, 2023 08:43
kobyhallx pushed a commit to noir-lang/acvm that referenced this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a method to get the public witness from the solved witness
2 participants