Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

feat!: Add initial oracle opcode #149

Merged
merged 12 commits into from
Mar 23, 2023
Merged

feat!: Add initial oracle opcode #149

merged 12 commits into from
Mar 23, 2023

Conversation

kevaundray
Copy link
Contributor

Related issue(s)

(If it does not already exist, first create a GitHub issue that describes the problem this Pull Request (PR) solves before creating the PR and link it here.)

Resolves (link to issue)

Description

This adds the oracle opcode which will allow us to load information from an external source

Summary of changes

(Describe the changes in this PR. Point out breaking changes if any.)

Dependency additions / changes

(If applicable.)

Test additions / changes

(If applicable.)

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Additional context

(If applicable.)

@kevaundray kevaundray marked this pull request as draft March 21, 2023 12:27
@kevaundray
Copy link
Contributor Author

Putting it as a draft because the solve method is still put as a todo

@joss-aztec joss-aztec mentioned this pull request Mar 23, 2023
5 tasks
@joss-aztec joss-aztec marked this pull request as ready for review March 23, 2023 11:07
@joss-aztec joss-aztec changed the title Add initial oracle opcode feat!: Add initial oracle opcode Mar 23, 2023
Copy link
Contributor

@guipublic guipublic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me, just have one comment.

acvm/src/pwg/oracle.rs Outdated Show resolved Hide resolved
acvm/src/pwg/oracle.rs Outdated Show resolved Hide resolved
@joss-aztec joss-aztec added this pull request to the merge queue Mar 23, 2023
Merged via the queue into master with commit 88ee2f8 Mar 23, 2023
@github-actions github-actions bot mentioned this pull request Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants