This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
chore!: Separate barretenberg solver from generic blackbox solver code #554
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
This attempts to rip the barretenberg solver from the actual solver trait. This should be done because wasm-bindgen is viral and infects anything that depends upon acvm and compiles to wasm, such as the LSP. When trying to compile the LSP to wasm, the bindgen tool crashes with the error outlined rustwasm/wasm-bindgen#2033; however, the LSP can just be compiled to wasm32-wasi if bindgen isn't polluting the wasm file.
Additional Context
PR Checklist*
cargo fmt
on default settings.