Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

chore!: Separate barretenberg solver from generic blackbox solver code #554

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

phated
Copy link
Contributor

@phated phated commented Sep 18, 2023

Description

Problem*

Resolves

Summary*

This attempts to rip the barretenberg solver from the actual solver trait. This should be done because wasm-bindgen is viral and infects anything that depends upon acvm and compiles to wasm, such as the LSP. When trying to compile the LSP to wasm, the bindgen tool crashes with the error outlined rustwasm/wasm-bindgen#2033; however, the LSP can just be compiled to wasm32-wasi if bindgen isn't polluting the wasm file.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench changed the title chore: Separate barretenberg solver from generic blackbox solver code chore!: Separate barretenberg solver from generic blackbox solver code Sep 18, 2023
Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There's a couple of nits plus I need to speak with kev about how we can fit this into the monorepoing.

barretenberg_blackbox_solver/Cargo.toml Outdated Show resolved Hide resolved
barretenberg_blackbox_solver/Cargo.toml Outdated Show resolved Hide resolved
@TomAFrench TomAFrench added this pull request to the merge queue Sep 19, 2023
Merged via the queue into master with commit a4b9772 Sep 19, 2023
16 checks passed
@kevaundray kevaundray mentioned this pull request Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants