Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

Have Directive::Log output format match println eval in acir gen #94

Closed
2 tasks
vezenovm opened this issue Feb 14, 2023 · 0 comments · Fixed by #97
Closed
2 tasks

Have Directive::Log output format match println eval in acir gen #94

vezenovm opened this issue Feb 14, 2023 · 0 comments · Fixed by #97
Assignees
Labels
bug Something isn't working

Comments

@vezenovm
Copy link
Contributor

Description

There were some changes to the print formatting when making this println statements PR on Noir: noir-lang/noir#630.

Aim

There are some Logs that require witness information that can only be fetched during solving of the witness. The directive had to be made before making changes to Noir so that Noir could access Directive::Log during acir gen. During PR review of noir-lang/noir#630 some of the print formatting changed. We should bring Directive::Log up to speed.

Expected behavior

That hex output for printing during acir gen and when we solve the witness should match.

Bug

The output during witness solving is outdated.

To reproduce

If you try and log values that requires solving the witness you will see the difference.

Environment

(Specify your setup and versions of dependencies.)

  • OS:

For nargo users

  • noir-lang/noir commit cloned:
  • Proving backend
    • default
      • Clang: (run clang --version)
    • wasm-base

For TypeScript users

  • Node.js: (run node --version)
  • @noir-lang/noir_wasm: (from yarn.lock)
  • @noir-lang/barretenberg: (from yarn.lock)
  • @noir-lang/aztec_backend: (from yarn.lock)

Additional context

(If applicable.)

@vezenovm vezenovm added the bug Something isn't working label Feb 14, 2023
@vezenovm vezenovm self-assigned this Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant