diff --git a/.github/actions/docs/build-status/script.sh b/.github/actions/docs/build-status/script.sh index a8d31ff4f4b..0b282557cf2 100755 --- a/.github/actions/docs/build-status/script.sh +++ b/.github/actions/docs/build-status/script.sh @@ -18,11 +18,11 @@ while [[ "$DEPLOY_STATUS" != "ready" && $COUNT -lt $MAX_RETRIES ]]; do exit 0 elif [[ "$DEPLOY_STATUS" == "error" ]]; then echo "deploy_status=failure" >> $GITHUB_OUTPUT - exit 0 + exit 1 fi echo "Deploy still running. Retrying..." done echo "deploy_status=failure" >> $GITHUB_OUTPUT -exit 0 +exit 1 diff --git a/.github/workflows/build-docs.yml b/.github/workflows/build-docs.yml index af3565ba61d..23ae0e409e9 100644 --- a/.github/workflows/build-docs.yml +++ b/.github/workflows/build-docs.yml @@ -100,9 +100,11 @@ jobs: site-id: ${{ secrets.NETLIFY_SITE_ID }} continue-on-error: true + - name: Debugging - print deploy_status run: echo "${{ steps.check_deploy_status.outputs.deploy_status }}" + - name: Change PR Comment for Successful Deployment if: steps.check_deploy_status.outputs.deploy_status == 'success' uses: mshick/add-pr-comment@v2 @@ -134,3 +136,7 @@ jobs: Deployment didn't succeed. Please check logs below and resolve the issue 🧐 [![Netlify Status](https://api.netlify.com/api/v1/badges/${{ secrets.NETLIFY_SITE_ID }}/deploy-status?branch=${{ github.head_ref || github.ref }})](https://app.netlify.com/sites/noir-docs-v2/deploys) + + - name: Fail the workflow if deployment failed + if: steps.check_deploy_status.outputs.deploy_status == 'failure' + run: exit 1 diff --git a/docs/docs/language_concepts/01_functions.md b/docs/docs/language_concepts/01_functions.md index c42aa9eab12..47cdea0cf04 100644 --- a/docs/docs/language_concepts/01_functions.md +++ b/docs/docs/language_concepts/01_functions.md @@ -160,12 +160,14 @@ fn main() { Also note that impls with the same method name defined in them cannot overlap. For example, if we already have `foo` defined for `Foo` and `Foo` like we do above, we cannot also define `foo` in an `impl Foo` since it would be ambiguous which version of `foo` to choose. -```rs +```rust // Including this impl in the same project as the above snippet would // cause an overlapping impls error impl Foo { fn foo(self) -> Field { 3 } } +``` + ## Lambdas Lambdas are anonymous functions. They follow the syntax of Rust - `|arg1, arg2, ..., argN| return_expression`.