Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler): Allows specify entry_point source #1026

Merged
merged 9 commits into from
Mar 23, 2023
Merged

Conversation

kobyhallx
Copy link
Contributor

Related issue(s)

#1025

Resolves #1025

Description

feat(compiler): Allows specify entry_point source
feat(chore): allows to configure Logger in WASM

Dependency additions / changes

log
wasm-logger

Test additions / changes

N/A

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.: entry_point attribute added to options will instruct the compiler to resolve the file specified. In NodeJS CJS this will use provided file system-based source resolver, while in any ESM environment it will need to rely on a resolver provided through initialiseResolver.

Additional context

@kobyhallx kobyhallx marked this pull request as ready for review March 22, 2023 12:29
Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, we're just accumulating enough code in this crate where I think we should start thinking about organisation.

crates/wasm/src/lib.rs Show resolved Hide resolved
crates/wasm/src/lib.rs Outdated Show resolved Hide resolved
crates/fm/src/file_reader.rs Show resolved Hide resolved
crates/wasm/src/lib.rs Show resolved Hide resolved
crates/wasm/src/lib.rs Outdated Show resolved Hide resolved
crates/wasm/src/lib.rs Outdated Show resolved Hide resolved
kobyhallx and others added 5 commits March 23, 2023 12:57
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
@kobyhallx kobyhallx added this pull request to the merge queue Mar 23, 2023
Merged via the queue into master with commit 9789f89 Mar 23, 2023
@kobyhallx kobyhallx deleted the kh-init-log branch March 23, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow entry_point in WASM compile
2 participants