Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid asserting in typechecker if struct field count is not correct #1036

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

jfecher
Copy link
Contributor

@jfecher jfecher commented Mar 24, 2023

Related issue(s)

Resolves #1028

Description

Summary of changes

If the user provides an incorrect number of fields, this error is caught and issues during name resolution, however typechecking would later panic with an assert rather than continuing typechecking and skipping these malformed sections. Since the compiler should continue on error rather than abort, this behavior is incorrect and has been fixed so that the compiler no longer crashes.

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

Additional context

@jfecher jfecher changed the title Avoid asserting in typechecker if struct field count is not correct fix: Avoid asserting in typechecker if struct field count is not correct Mar 27, 2023
@jfecher jfecher added this pull request to the merge queue Mar 27, 2023
Merged via the queue into master with commit b3d1d7f Mar 27, 2023
@jfecher jfecher deleted the jf/check-constructors branch March 27, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constructors do not check the required number of fields
2 participants