Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ssa refactor): Change types to be stored in the value rather than the instruction result #1218

Closed
1 task
jfecher opened this issue Apr 25, 2023 · 0 comments
Closed
1 task
Labels
enhancement New feature or request

Comments

@jfecher
Copy link
Contributor

jfecher commented Apr 25, 2023

Problem

Instructions are currently stored on the instruction result which makes them very dependent on passing around a ctrl_typevar to determine the type of operations. In practice, this means we must pass a type in every time we insert a new instruction into an ssa function in the refactor.

Proposed solution

We can avoid this if we store the types of values so that we can use these to determine the instruction type (if possible) instead.

Alternatives considered

No response

Additional context

No response

Submission Checklist

  • Once I hit submit, I will assign this issue to the Project Board with the appropriate tags.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant