Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Barretenberg specific code/comments from SSA #1307

Closed
1 task done
Tracked by #1376
kevaundray opened this issue May 6, 2023 · 2 comments
Closed
1 task done
Tracked by #1376

Remove Barretenberg specific code/comments from SSA #1307

kevaundray opened this issue May 6, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request refactor ssa
Milestone

Comments

@kevaundray
Copy link
Contributor

Problem

In certain places in SSA, we mention or apply logic for Barretenberg. One place this happens is when we have an odd range constraint. Since Barretenberg does not support odd range constraints, a much more in-efficient strategy is being used. As opposed to just using the range constraint black box function.

Proposed solution

Barretenberg should be made to deal with odd bit size range constraints in its backend and the code in SSA should be removed so that it does not affect non-barretenberg backends

Alternatives considered

No response

Additional context

No response

Submission Checklist

  • Once I hit submit, I will assign this issue to the Project Board with the appropriate tags.
@kevaundray kevaundray added enhancement New feature or request refactor ssa labels May 6, 2023
@kevaundray kevaundray changed the title Remove Barretenberg specific code from SSA Remove Barretenberg specific code/comments from SSA May 6, 2023
@kevaundray
Copy link
Contributor Author

This is also the case for starting witness indices at 0.

This however could be something we put into ACIR so that frontends can have a zero value and we make it a standard that Witness(0) refers to 0, and possibly Witness(1) refers to 1. We should then move the methods which increment the Witness to ACIR.

Barretenberg could deal with this by applying one to all witness indices (since the compiler will start off from 0)

@kevaundray
Copy link
Contributor Author

Before closing this, we should check in ssa folder, if this is still the case

@kevaundray kevaundray added this to the 1.0 milestone Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor ssa
Projects
Archived in project
Development

No branches or pull requests

4 participants