Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider having the frontend disallow as u{FieldElement::max_num_bits()} conversions #1443

Closed
Tracked by #1376
kevaundray opened this issue May 30, 2023 · 4 comments
Closed
Tracked by #1376
Assignees
Labels
enhancement New feature or request refactor ssa

Comments

@kevaundray
Copy link
Contributor

Problem

As noted in this comment here we can push the FieldElement check to the frontend.

Its not necessary, but keeping this as tracking issue.

Happy Case

.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@kevaundray
Copy link
Contributor Author

This should also be solved with #1433 (comment)

@kevaundray
Copy link
Contributor Author

@guipublic can you check the status of this issue?

@guipublic
Copy link
Contributor

The check is still not on the frontend side

@guipublic
Copy link
Contributor

I checked again and now bit size >= FieldElement::max_num_bits() are matched in the frontend (in the Lexer). I am closing the issue then.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor ssa
Projects
Archived in project
Development

No branches or pull requests

2 participants