Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proper error handling in SSA for errors caused by user inputs #1473

Closed
Tracked by #1376
kevaundray opened this issue May 31, 2023 · 3 comments
Closed
Tracked by #1376

Add proper error handling in SSA for errors caused by user inputs #1473

kevaundray opened this issue May 31, 2023 · 3 comments
Assignees
@Ethan-000
Labels
enhancement New feature or request refactor ssa

Comments

@kevaundray
Copy link
Contributor

Problem

In AcirVar we have a few expects which should be turned into Result<T, Error>

Happy Case

.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@kevaundray kevaundray added enhancement New feature or request refactor ssa labels May 31, 2023
@Savio-Sou Savio-Sou mentioned this issue Jun 2, 2023
Closed
@kevaundray
Copy link
Contributor Author

This would essentially entail removing unecessary unwraps and expects, where we intended to return an error

This was referenced Jul 27, 2023
Merged
Closed
@Ethan-000 Ethan-000 removed their assignment Aug 2, 2023
@Ethan-000
Copy link
Contributor

adding some context #2111 (comment) to this issue

@Ethan-000 Ethan-000 changed the title Add proper error handling in SSA Add proper error handling in SSA for errors caused by user inputs Aug 3, 2023
@Ethan-000
Copy link
Contributor

I think I'll still assign myself to this and see if I can find time to report all the user errors

@Ethan-000 Ethan-000 self-assigned this Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ethan-000 Ethan-000

Labels
enhancement New feature or request refactor ssa
Projects
Noir
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kevaundray @Ethan-000 @Savio-Sou