Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SSA value substitution #1592

Closed
joss-aztec opened this issue Jun 7, 2023 · 2 comments
Closed

Fix SSA value substitution #1592

joss-aztec opened this issue Jun 7, 2023 · 2 comments
Assignees
@jfecher
Labels
bug Something isn't working refactor ssa

Comments

@joss-aztec
Copy link
Contributor

Aim

Fix bugs present in the ssa printer and ACIR gen

Expected Behavior

During SSA passes (namely mem2reg), we should substitute ValueIds at their point of use instead of changing a ValueId's underlying Value.

Bug

To Reproduce

Installation Method

None

Nargo Version

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@joss-aztec joss-aztec added bug Something isn't working refactor ssa labels Jun 7, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jun 7, 2023
@joss-aztec joss-aztec mentioned this issue Jun 7, 2023
Merged
5 tasks
@joss-aztec joss-aztec changed the title Retire dfg's set_value and set_value_from_id Fix SSA value substitution Jun 12, 2023
@kevaundray
Copy link
Contributor

@jfecher whats the status of this?

@jfecher
Copy link
Contributor

jfecher commented Jul 21, 2023

This was fixed when we added the replaced_value_ids map

@jfecher jfecher closed this as completed Jul 21, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfecher jfecher

Labels
bug Something isn't working refactor ssa
Projects
Noir
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jfecher @kevaundray @joss-aztec