Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nargo): prevent -p arg clash #1605

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Conversation

joss-aztec
Copy link
Contributor

Description

Problem*

The introduction on --prover-name causes nargo execute to crash because the argument's short form clashes with --print-acirs's.

Summary*

Prevent the clash, by removing the short form for --print-acir.

Example

Before:

The application panicked (crashed).
Message:  Command execute: Short option names must be unique for each argument, but '-p' is in use by both 'prover_name' and 'print_acir'
Location: /Users/aztec/.cargo/registry/src/github.com-1ecc6299db9ec823/clap_builder-4.3.0/src/builder/debug_asserts.rs:115

After:

(Now runs correctly)

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should add an integration test to ensure that this doesn't occur again in future.

@joss-aztec joss-aztec enabled auto-merge June 8, 2023 11:16
@joss-aztec joss-aztec added this pull request to the merge queue Jun 8, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 8, 2023
@jfecher jfecher added this pull request to the merge queue Jun 8, 2023
Merged via the queue into master with commit 4867f4e Jun 8, 2023
@jfecher jfecher deleted the joss/rm-print-acir-short-arg branch June 8, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants