Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ssa refactor): Implement merging of array values during flattening pass #1767

Merged
merged 2 commits into from
Jun 21, 2023
Merged

fix(ssa refactor): Implement merging of array values during flattening pass #1767

merged 2 commits into from
Jun 21, 2023

Conversation

jfecher
Copy link
Contributor

@jfecher jfecher commented Jun 20, 2023

Description

Problem*

Resolves #1486

Summary*

Merges array values by recursively merging each element and creating a new array from the result.

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@jfecher jfecher mentioned this pull request Jun 20, 2023
Closed
@kevaundray kevaundray added this pull request to the merge queue Jun 20, 2023
Merged via the queue into master with commit 8f24751 Jun 21, 2023
@kevaundray kevaundray deleted the jf/merge-arrays branch June 21, 2023 01:28
This was referenced Jun 21, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(SSA Refactor): Returning arrays from if statements results in incorrect IR
2 participants
@jfecher @kevaundray