fix(ssa refactor): Fix recursive call to create_value_from_type

[jfecher]

Description

Problem*

The "missing assignment for witness index" error was caused by an incorrect call in the array-element case of create_value_from_type which should have been a recursive call but instead was still calling convert_ssa_block_param. This was an oversight from PR #1797.

Resolves #1799

Summary*

With this PR sha2_byte and sha2_block no longer hit this error and instead run into a "cannot satisfy all constraints" error as in #1800.

Documentation

• This PR requires documentation updates when merged.

  • I will submit a noir-lang/docs PR.
  • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

• I have tested the changes locally.
• I have formatted the changes with Prettier and/or cargo fmt on default settings.

[ludamad]

Should we now copy sha2 bytes over?

[jfecher]

@ludamad nope :/

With this PR sha2_byte and sha2_block no longer hit this error and instead run into a "cannot satisfy all constraints" error as in #1800.

Just more bugs hiding behind this bug