Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow main to be a brillig function #1861

Merged
merged 1 commit into from
Jul 4, 2023
Merged

feat: allow main to be a brillig function #1861

merged 1 commit into from
Jul 4, 2023

Conversation

sirasistant
Copy link
Contributor

@sirasistant sirasistant commented Jul 4, 2023 •
edited
Loading

Description

Problem*

This PR enables unconstrained fns to be main by adding the capability to acir gen to generate the wrapper ACIR necessary for input/output of a brillig function.

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@sirasistant sirasistant added this pull request to the merge queue Jul 4, 2023
vezenovm
vezenovm reviewed Jul 4, 2023
View reviewed changes
Copy link
Contributor

@vezenovm vezenovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me once Jake's comments are addressed

Merged via the queue into master with commit 1330a2a Jul 4, 2023
@sirasistant sirasistant deleted the arv/unconstrained_main branch July 4, 2023 15:35
@kevaundray kevaundray mentioned this pull request Jul 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vezenovm vezenovm vezenovm left review comments

@jfecher jfecher jfecher approved these changes

@kevaundray kevaundray Awaiting requested review from kevaundray

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sirasistant @jfecher @vezenovm