Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The LSP should add the --program-dir flag to the test command #2291

Closed
phated opened this issue Aug 11, 2023 · 0 comments
Closed

The LSP should add the --program-dir flag to the test command #2291

phated opened this issue Aug 11, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@phated
Copy link
Contributor

phated commented Aug 11, 2023

Problem

Currently, if you have a vscode project that doesn't have a Nargo.toml file at the root, the nargo test command panics because it does not think there is any nargo package in the project. However, there could be a subdirectory that contains a nargo package and we're running a test inside of it. Since the LSP knows where the root of that workspace is, we can add --program-dir to the nargo test command and it'll work.

See also noir-lang/vscode-noir#28 for more information.

Happy Case

Using the Run Test lens in vscode should always work.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

Yes

Support Needs

No response

@phated phated added the enhancement New feature or request label Aug 11, 2023
@phated phated self-assigned this Aug 11, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Aug 11, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

1 participant