Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integers should be printed as normal integers instead of fields #2401

Closed
phated opened this issue Aug 22, 2023 · 3 comments · Fixed by #3577
Closed

Integers should be printed as normal integers instead of fields #2401

phated opened this issue Aug 22, 2023 · 3 comments · Fixed by #3577
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@phated
Copy link
Contributor

phated commented Aug 22, 2023

Problem

Currently, when printing an integer, it is converted to a string via format_field_string even though we track it as an integer in the program boundary. These should be printed as normal integers.

Happy Case

Using println(f"{}", 1) should print 1 instead of 0x01.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@phated phated added enhancement New feature or request good first issue Good for newcomers labels Aug 22, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Aug 22, 2023
@jfecher
Copy link
Contributor

jfecher commented Aug 22, 2023

I'd like for us to do this for fields as well to be honest. If users want a hex representation we should represent this through the string formatting options.

@Savio-Sou
Copy link
Collaborator

cc @tsujp as you might find this interesting given the prettify print bash script you've already put together!

@tsujp
Copy link
Contributor

tsujp commented Sep 7, 2023

cc @tsujp as you might find this interesting given the prettify print bash script you've already put together!

When I get a tiny bit more bandwidth (trying to stay laser focused on ZK Fog of War Chess and EPF right now) I'll have a crack at a PR for this, may be 1 or 2 weeks until I start having said crack though.

It'd probably be useful to have other format specifiers too e.g. integer to ASCII as in my script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants