Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve messages for Noir program tests that gets executed after running nargo test #2438

Open
Tracked by #2441
Ethan-000 opened this issue Aug 25, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Ethan-000
Copy link
Contributor

Problem

Copying from #2418 (comment)

This is something we should do in a separate issue, when a test should fail, but it passes. There is no red line to tell us what passed that should not have passed. This is in comparison to the opposite. To illustrate, run nargo test on these two pieces of code:

#[test]
fn foo(){
    assert(1 == 2);
}
#[test(should_fail)]
fn foo(){
    assert(1 == 1);
}

and quoting @phated "I think we can follow on with more descriptive error messages (such as what kev mentioned or noting that a test failed because it succeeded but was expected to fail)"

i also think this error message is not printed https://github.com/noir-lang/noir/blob/master/crates/nargo_cli/src/cli/test_cmd.rs#L134-L141. might be wrong about this. didn't take a very close look at it.

Happy Case

more descriptive, better formatted error messages for tests

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

Maybe

Support Needs

No response

@Ethan-000 Ethan-000 added the enhancement New feature or request label Aug 25, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Aug 25, 2023
@Ethan-000 Ethan-000 added good first issue Good for newcomers P-LOW labels Aug 25, 2023
@Ethan-000 Ethan-000 changed the title Improve messages for tests Improve messages for Noir program tests that gets executed after running nargo test Aug 25, 2023
@kevaundray kevaundray added this to the 0.25 milestone Jan 15, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jan 20, 2024
@TomAFrench TomAFrench reopened this Jan 20, 2024
@Savio-Sou Savio-Sou removed this from the 0.25 milestone Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Done
Development

No branches or pull requests

4 participants