Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove base64 encoding from acir artifacts #2469

Closed
kevaundray opened this issue Aug 29, 2023 · 2 comments · Fixed by #2470
Closed

Remove base64 encoding from acir artifacts #2469

kevaundray opened this issue Aug 29, 2023 · 2 comments · Fixed by #2470
Labels
enhancement New feature or request

Comments

@kevaundray
Copy link
Contributor

Problem

The acir artifacts are currently being base4 encoded because they are included in the ABI.json file.

For backend end to end tests, they don't need to have a base64 encoded file since they just get the raw bytecode and not the json file.

Happy Case

base64 decode file before saving it in .bytecode

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@kevaundray kevaundray added enhancement New feature or request P-LOW labels Aug 29, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Aug 29, 2023
@Savio-Sou
Copy link
Collaborator

Savio-Sou commented Aug 30, 2023

cc Tooling @kobyhallx @TomAFrench @jonybur @phated

Is base64 encoding no longer needed for the E2E workflow with barretenberg (bb.js)?

@TomAFrench
Copy link
Member

Nope, we're passing just the circuit rather than the full JSON artifact so we can pass binary.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants