Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend browser integration-tests to cover verification with Solidity verifier #2694

Closed
Tracked by #2163
Savio-Sou opened this issue Sep 14, 2023 Discussed in #2690 · 0 comments · Fixed by #2749
Closed
Tracked by #2163

Extend browser integration-tests to cover verification with Solidity verifier #2694

Savio-Sou opened this issue Sep 14, 2023 Discussed in #2690 · 0 comments · Fixed by #2749
Assignees
Labels
enhancement New feature or request

Comments

@Savio-Sou
Copy link
Collaborator

Discussed in https://github.com/orgs/noir-lang/discussions/2690

Originally posted by Savio-Sou September 14, 2023

Problem

The current compile_prove_verify.test.ts headless browser test covers:

  1. Compilation
  2. Execution
  3. Proving with bb.js
  4. Verifying with bb.js

Noir app devs often want proofs to also be verifiable by barretenberg's Solidity verifier, which isn't currently tested in CI.

Happy Case

Extend the test above to also test verification of the proofs generated with Solidity verifiers generated by bb binary.

Note:

  • NOT Solidity verifiers from bb.js as the recommended Noir dev workflow generates Solidity verifiers in the CLI
  • For minimizing CI times, Solidity verifiers can be cached and regenerated only when the bb.js version tested against is bumped

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@Savio-Sou Savio-Sou added the enhancement New feature or request label Sep 14, 2023
@Savio-Sou Savio-Sou added this to Noir Sep 14, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Sep 14, 2023
@jonybur jonybur self-assigned this Sep 18, 2023
@jonybur jonybur linked a pull request Sep 19, 2023 that will close this issue
5 tasks
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants