Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sha2_blocks test case #3214

Closed
guipublic opened this issue Oct 18, 2023 · 0 comments · Fixed by #3360
Closed

Remove sha2_blocks test case #3214

guipublic opened this issue Oct 18, 2023 · 0 comments · Fixed by #3360
Labels
enhancement New feature or request

Comments

@guipublic
Copy link
Contributor

Problem

sha2_blocks is a test case which is resource intensive and generates a big circuit. However in term of feature it is doing the same as sha2_byte, except that it has a much bigger input (3, 56 and 112 bytes input vs one).

Having sha2_blocks as part of the CI is slowing down CI a lot which is not good, but it cannot help to find more issues, except, incidentally, performance issues when the CI hits its timeout and fail.
We should have a dedicated way to detect performance issues, and not rely and something that was not designed for this.

Happy Case

Remove sha2_blocks from the CI

Alternatives Considered

No response

Additional Context

The overflow checks PR #2713 fail CI because of this test case. It turns out it is because sha256 is only using wrapping operations, and their stdlib implementation is not performant. Creating the circuit takes 8 minutes with stdlib wrapping. The resulting circuit is 20% bigger which seems OK.
We should analyse why stdlib wrapping takes more time and propose a builtin alternative.

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@guipublic guipublic added the enhancement New feature or request label Oct 18, 2023
@Savio-Sou Savio-Sou added this to Noir Oct 20, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Oct 20, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant