Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review API for serializing a circuit #3347

Open
kevaundray opened this issue Oct 29, 2023 · 0 comments
Open

Review API for serializing a circuit #3347

kevaundray opened this issue Oct 29, 2023 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@kevaundray
Copy link
Contributor

Problem

Currently we allow folks to serialize a circuit in two ways -- base64 encoded or using just bincode with compression. See this comment for the exact part of the code which does this.

First we should review the usages of serialization across the stack, in particular check out Noir.js to see where these two strategies collide and the friction it causes.

Happy Case

Ideally we only want one way to serialize a circuit, though this may not be possible without breaking conventions.

We use base64 for javascript because this is conventional , though maybe we should revisit this decision.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants