Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom modulus in the bigint opcode #4404

Closed
Tracked by #510
joeandrews opened this issue Feb 20, 2024 · 3 comments
Closed
Tracked by #510

Add support for custom modulus in the bigint opcode #4404

joeandrews opened this issue Feb 20, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@joeandrews
Copy link

Problem

Currently the bigint opcode uses a fixed set of 6 templated modulus. This is not generic and prevents developers using the opcode for custom modulus e.g RSA signatures or Curve25519 which requires a custom value.

It also prevents Noir from having U256 integers.

Happy Case

Barretenberg should support custom run time modulus definition.

Project Impact

Nice-to-have

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@joeandrews joeandrews added the enhancement New feature or request label Feb 20, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Feb 20, 2024
@TomAFrench
Copy link
Member

Let's add an issue for this in aztec-packages so crypto can see this @Savio-Sou

@Savio-Sou
Copy link
Collaborator

Savio-Sou commented Mar 4, 2024

Let's add an issue for this in aztec-packages

AztecProtocol/aztec-packages#4676

@TomAFrench
Copy link
Member

Closing this due to above issue + it seems like crypto isn't comfortable with this.

@TomAFrench TomAFrench closed this as not planned Won't fix, can't repro, duplicate, stale Apr 8, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

3 participants