Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename fixed_base_scalar_mul.rs #4932

Closed
benesjan opened this issue Apr 29, 2024 · 0 comments · Fixed by AztecProtocol/aztec-packages#6097
Closed

Rename fixed_base_scalar_mul.rs #4932

benesjan opened this issue Apr 29, 2024 · 0 comments · Fixed by AztecProtocol/aztec-packages#6097
Labels
enhancement New feature or request

Comments

@benesjan
Copy link
Contributor

Problem

The file now contains not just fixed_base_scalar_mul function but also embedded_curve_add and variable_base_scalar_mul.

Rename the following 2 files:
acvm-repo/acvm/src/pwg/blackbox/fixed_base_scalar_mul.rs
acvm-repo/bn254_blackbox_solver/src/fixed_base_scalar_mul.rs

Happy Case

The file should be renamed to something more generic.

Project Impact

Nice-to-have

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant