feat(ci): Add workflow to validate PR title #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phated
changed the title
phated
changed the title
phated
commented
Feb 1, 2023
phated
changed the title
|
Y'all can try changing the title to see how the PR title lint action works. |
phated
requested review from
guipublic,
jfecher,
joss-aztec,
kevaundray,
kobyhallx,
TomAFrench and
vezenovm
phated
commented
Feb 3, 2023
kevaundray
changed the title
kevaundray
changed the title
phated
force-pushed
the
phated/release-process
branch
from
4dc28a1
to
686fbb5
Compare
|
From conversation with @phated: Will need to add this in the branch protection settings |
phated
force-pushed
the
phated/pr-title-check
branch
from
e47ffef
to
70aef62
Compare
kevaundray
approved these changes
Feb 3, 2023
TomAFrench
added a commit
to TomAFrench/noir
that referenced
this pull request
Feb 3, 2023
* master: feat(nargo): Add `nargo test` command to run all unit tests (noir-lang#728) chore(ci): Apply `doc needed` label automatically on PRs (noir-lang#733) chore(ci): Remove failing bors workflow (noir-lang#744) feat(ci): Add workflow to validate PR title (noir-lang#730) feat(docs): Introduce Conventional Commits & release process docs (noir-lang#717)
TomAFrench
added a commit
that referenced
this pull request
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
N/A
Description
This is a follow on to #717 that adds a PR title validation to CI. This should help to ensure we don't accidentally merge a PR with the wrong message when used in conjunction with these github settings:
While not perfect, it'll catch our common mistakes.
Summary of changes
Adds the CI action that happens on
pull_requestorpull_request_targetusing onlypull-request: readpermissions which will check the PR title is valid or fail a check.Dependency additions / changes
Test additions / changes
Checklist
cargo fmtwith default settings.Additional context