fix: operators issuing type errors when used with matching integer types arising from generic code #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfecher
changed the title
jfecher
changed the title
vezenovm
approved these changes
Feb 9, 2023
guipublic
approved these changes
Feb 10, 2023
TomAFrench
added a commit
that referenced
this pull request
Feb 14, 2023
* master: (28 commits) chore(ci): Add release token to enable runs against release PR (#840) feat(ssa): array sort (#754) chore: update readme (#811) chore: fix clippy (#825) chore: remove stale comment on HirFunction.unchecked_from_expr (#827) chore: Getter naming refactor (#803) chore: updated "HirFunction::unsafe_from_expr" to "HirFunction::unchecked_from_expr" (#823) chore: Forbid unsafe code (#824) chore: Follow rust naming convention (#801) feat(ci): Add concurrency group for rust workflow (#806) chore(ssa): rename impl method to follow Rust guideline (#782) fix(nargo): `nargo test` now only runs test functions defined in the current module (#805) chore(nargo): Remove outdated error message when Prover/Verifier.toml is missing (#807) chore(ssa): rename codegen to ssa_gen + reorg of `Value` struct (#797) chore(nargo): abstract paths from nargo's working directory (#761) chore(ci): Rename workflows (#804) feat: Impls with generics (#798) chore(ssa): Add doc comments on `Opcode` struct (#778) fix: operators issuing type errors when used with matching integer types arising from generic code (#789) chore(nargo)!: bump MSRV to 1.66.0 (#799) ...
|
Just to confirm: nothing needs to be documented here right? |
|
@Globallager correct. Apologies for the confusion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #788
Description
Summary of changes
The match expression in
infix_operand_type_rulesand the matching function for comparator operators had its match case forTypeVariablesat the end instead of at the beginning. This meant that other catch-all cases like(Integer, _)could be matched instead and issue errors when matching on a(Integer, TypeVariable)pair, even if the type variable is bound to an integer.The fix to this is to reorder the match so that the cases with type variables are first so that their links will be correctly followed.
Dependency additions / changes
Test additions / changes
Checklist
cargo fmtwith default settings.Additional context