Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nargo)!: restrict CliError visibility to crate #911

Merged
merged 3 commits into from
Feb 24, 2023

Conversation

TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented Feb 24, 2023

Related issue(s)

Followup to #907

Description

Summary of changes

CliError shouldn't be made public so I've adjusted its visibility to ensure that it stays only visible within the crate. I've had to adjust the visibility of other functions to match (we don't change the crate's interface doing this however).

This PR is technically breaking as we've removed the check_from_path from the crate interface.

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.
  • This PR requires documentation updates when merged.

Additional context

@TomAFrench TomAFrench changed the title chore: restrict CliError visibility to crate chore!: restrict CliError visibility to crate Feb 24, 2023
@TomAFrench TomAFrench changed the title chore!: restrict CliError visibility to crate chore(nargo)!: restrict CliError visibility to crate Feb 24, 2023
@kevaundray kevaundray added this pull request to the merge queue Feb 24, 2023
Merged via the queue into master with commit ed0e1ab Feb 24, 2023
@kevaundray kevaundray deleted the cli-error-visibility branch February 24, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants