Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nargo)!: rename contract command to codegen-verifier #959

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

TomAFrench
Copy link
Member

Related issue(s)

Resolves #945

Description

Summary of changes

I've renamed the nargo contract command to nargo codegen-verifier. codegen is shorter than generate and is more descriptive so I opted for this name instead of what's discussed in #945 (happy to switch if there's strong feelings about this).

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

Additional context

@kevaundray
Copy link
Contributor

Did you consider 'gen-verifier' ?

@TomAFrench
Copy link
Member Author

Yeah, I did. It felt a little too abbreviated in my mind. "codegen" is a well-known term but "gen" has no meaning until the user makes the leap to "generate"

@kevaundray
Copy link
Contributor

Fair, I have no strong opinion re this. Quick ping to @noir-lang/tooling

@kevaundray
Copy link
Contributor

I pinged @joss-aztec since he replied to the original issue and he says your new suggestion is even better

@kevaundray kevaundray added this pull request to the merge queue Mar 7, 2023
Merged via the queue into master with commit 2e63492 Mar 7, 2023
@kevaundray kevaundray deleted the rename-contract-command branch March 7, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename nargo contract command
2 participants