feat: separate contract/program compilation from IO #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
force-pushed
the
compile-contract-logic
branch
from
ea5abd8
to
b8be9cc
Compare
TomAFrench
force-pushed
the
compile-contract-logic
branch
from
b8be9cc
to
4e13b6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #966 (Although we'll need to do more on this in future)
Description
Summary of changes
I've created a separate function to compile a Noir contract compared to a single Noir program which returns a specialised struct for the compilation output of contracts.
These two functions are also now separated from IO, so could be reused in future for compilation in wasm (Most likely after the
nargo-core/nargo-clisplit?).Dependency additions / changes
Test additions / changes
Checklist
cargo fmtwith default settings.Documentation needs
Additional context