Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Run on macos-13 to avoid nix failure #1738

Merged
merged 2 commits into from
Jun 16, 2023
Merged

chore(ci): Run on macos-13 to avoid nix failure #1738

merged 2 commits into from
Jun 16, 2023

Conversation

phated
Copy link
Contributor

@phated phated commented Jun 16, 2023

Description

Problem*

Resolves

Summary*

According to cachix/install-nix-action#183, the nix github action doesn't fail on macos-13. Hopefully the stops our CI from flaking on mac.

I also updated the workspace settings to ensure the workflows are validated correctly by the yaml plugin.

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@phated phated requested review from kevaundray and kobyhallx June 16, 2023 18:04
@phated phated added this pull request to the merge queue Jun 16, 2023
Merged via the queue into master with commit cd1acdb Jun 16, 2023
@phated phated deleted the phated/mac13 branch June 16, 2023 20:32
@phated
Copy link
Contributor Author

phated commented Jun 16, 2023

They also released a new action, so we could go back to macos-latest but update the action.

@kevaundray
Copy link
Contributor

They also released a new action, so we could go back to macos-latest but update the action.

If this works that would be great! Just so we keep CI on the latest macOS-runner images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants